Pull Request Review Events

Projects RADIUSS Home

tldahlgren reviewed a spack/spack pull request

(Re-)Confirmed branch and all 57 version sha256….

View Review

rashawnLK reviewed a spack/spack pull request

Thanks Wil! This looks good….

View Review

zackgalbreath reviewed a spack/spack pull request

Thanks for fixing this so quickly!…

View Review

adamjstewart reviewed a spack/spack pull request

Solves the issue I reported on Slack. Not confident enough in this part of Spack to pull the trigger and merge. Would be great to get reviews from others….

View Review

mlstowell reviewed a mfem/mfem pull request

There are still a couple outstanding small comments but I’m sure they will be addressed. Thanks @dylan-copeland! This is a useful tool (and a challenge to other developers to add mixed element support). …

View Review

waynemitchell reviewed a hypre-space/hypre pull request

Looks good except my one minor comment above. Thanks, @oseikuffuor1 !…

View Review

rfalgout reviewed a hypre-space/hypre pull request

Looks good modulo our discussion about size_in. Thanks! …

View Review

grondo reviewed a flux-framework/flux-core pull request

This LGTM. Nice job catching the exception note corner case!…

View Review

pelesh reviewed a LLNL/hiop pull request

This branch is well tested and ready to merge. It might be a good idea to get the updated version of Ginkgo on all CI pipelines first….

View Review

davidbeckingsale reviewed a LLNL/RAJA pull request

View Review

agcapps reviewed a LLNL/RAJA pull request

Looks good…

View Review

MrBurmark reviewed a LLNL/RAJA pull request

View Review

TotoGaz reviewed a GEOSX/LvArray pull request

View Review

agcapps reviewed a LLNL/conduit pull request

Thanks, Cyrus….

View Review

castelletto1 reviewed a GEOSX/LvArray pull request

View Review

agcapps reviewed a LLNL/CARE pull request

If this fixes CARE’s GitHub CI, that’s what we need. But I’m still curious about the possibility of the fix (jwlawson?) going away. (Maybe that concern isn’t warranted.)…

View Review

liu15 reviewed a LLNL/CARE pull request

View Review

chapman39 reviewed a LLNL/blt pull request

View Review

v-dobrev reviewed a GLVis/glvis pull request

View Review

ryannova reviewed a LLNL/merlin-spellbook pull request

View Review

rfalgout reviewed a XBraid/xbraid pull request

Looks good, Jacob! …

View Review