markcmiller86 reviewed a visit-dav/visit pull request
I was just taking a look and see that @brugger1 beat me too it ;) …
becker33 reviewed a spack/spack pull request
I think this PR needs some additional thought to consider what happens if the user is requesting
tcl modules but the external modules are written in
lmod. The opposite direction is ok since lmod reads tcl modules, but that direction would cause a problem….
rfalgout reviewed a hypre-space/hypre pull request
Looks good to me. Thanks! …
BradWhitlock reviewed a LLNL/axom pull request
Nice, clean code….
liruipeng reviewed a hypre-space/hypre pull request
Looks good to me. Thanks!…
kennyweiss reviewed a LLNL/blt pull request
Thanks @mcfadden8 …
milroy reviewed a flux-framework/flux-sched pull request
Looks good to me; thanks! Setting MWP….
lucpeterson reviewed a LLNL/merlin-spellbook pull request
If you wanted to add another test, I’d suggest using make-samples option “grid” which won’t be random. You can then check for specific answers, eg confirming that round_0 gives the same as round and that round_N gives an expected result. But what you did is pretty much what I would have…